search

rubyforgood / inkind-admin

A project serving Community Education Partnerships - https://www.cep.ngo/ . This Rails application presents an admin interface for CEP to manage their volunteers and students. And provides a GraphQL backend for https://github.com/rubyforgood/inkind-volunteer .
MIT License
9 stars 27 forks source link

Standardize Date representations #133

Closed garettarrowood closed 2 years ago

garettarrowood commented 2 years ago

Summary

As a admin, I want a consistent representation of dates.

Things to Consider

There are a few different representations of dates in the application right now. Let's unify them to only one format for consistency.

Criteria for Completion

roman-rezinkin commented 2 years ago

Hi @garettarrowood, I would like to attempt at fixing this, could I please be assigned?

roman-rezinkin commented 2 years ago

Quick question, by the user interface would you mean by just displaying them in the front end, or fully changing them to a new format in the backend? Looking through the codebase right now, I can see that the backend uses ISO8601, which could just be formatted correctly in the front end. Is that what you are looking to achieve @garettarrowood

garettarrowood commented 2 years ago

Sorry for the confusion!

These issues get labeled with "backend" because there is a TypeScript/React app grabbing data via GraphQL, inkind-volunteer, which is referred to as the "frontend".

But in reality, this application has a user interface (it has a FE and BE in it). And this story just embodies how those dates are viewed in this app. So the frontend of this codebase.

Why all the confusion? Ease in telling the difference between the two repos on our project board.

roman-rezinkin commented 2 years ago

I am having a lot of issues with setup, so unfortunately I cannot contribute to help fix the format of the dates. I am not sure if it is because I am on Windows 10, but I have been trying to deploy the front end and backend for a few days with no success. Sorry.

garettarrowood commented 2 years ago

Sorry to hear you are having trouble, @roman-rezinkin . If you have any error output, feel free to drop it into an issue and hopefully I or someone else can try to find a solution.