Closed garettarrowood closed 2 years ago
@garettarrowood just my opinion, but I feel like the Information label is not really needed, as the heading is pretty much self-explanatory. What do you think?
@Ashvith - Agreed. -- The design for all of the forms in this app have that "Information" label at the top. We'll either not do it anywhere, or the designer will convince me it has value and one PR can add it across the board. -- In this issue, please leave it out :).
@garettarrowood what about the Phone Number text box? It is not present in the page originally. Should I just provide a dummy text input?
I also have the same opinion of the Back button, and the Cancel button. In this case, both would do the same action, that is, <%=link_to "...", :back%>
Back and Cancel are the same, yes.
Leave the Phone Number off. We can add it if it's ever needed (which I don't think it ever will be).
Should I assign this one to you?
@garettarrowood yes, please do assign me. I've completed this one, and I'll push my PR in a few minutes.
@garettarrowood I am not experienced enough to join the two input text box into a single drop-down text box. Maybe we can open another issue for the same?
@Ashvith - For sure - I don't think we will ever do that actually. See my comments on your PR, just a couple more changes and things look good to go.
Summary
Update the styles on the Organization form to match the mockup.
Things to Consider
The student form has the most up-to-date-ish styling so far. Feel free to reference that to align conventions.
Criteria for Completion
How it looks now:
How it will look after this change:
Note: Keep City/State easy. They should be two separate inputs, as they are stored on the table.