Updated Organization form

rubyforgood / inkind-admin

A project serving Community Education Partnerships - https://www.cep.ngo/ . This Rails application presents an admin interface for CEP to manage their volunteers and students. And provides a GraphQL backend for https://github.com/rubyforgood/inkind-volunteer .

MIT License

9 stars 27 forks source link

Updated Organization form #176

Closed ghost closed 2 years ago

ghost commented 2 years ago

Resolves #160

Description

Added a CSS style for input-text (.text-input-common).
Applied the style for the textboxes, except for a few (mentioned below).
Also added the buttons Save and Cancel (with their respective button styles).
Did not include the Phone text box.
Did not join the City and State text box into a single, dropdown textbox.

Type of change

Bug fix (non-breaking change which fixes an issue)

Screenshots

Screenshot from 2021-12-10 20-17-01

garettarrowood commented 2 years ago

Looking great so far!

Could you:

Add the "Back" link at the top (see other forms)
Make the City and State inputs half the width (check out the Student form)
Make the State input a typeahead select (again, check the Student form for this. It should be as easy as copying over the same f.input configurations. Carmen was recently added to pull geographical regions)

ghost commented 2 years ago

I did not add the "Back" button because the code for Cancel and Back would have been the same then, but if it is needed, then I'll do as per the requirement.
This should be easy to work with.
I'll have a quick look, this should probably be easy as well.

garettarrowood commented 2 years ago

Looks like you've made the upgrades. Could you post an updated screenshot?

ghost commented 2 years ago

Sorry for the delayed reply, here is a screenshot of the same. I was not able to figure out how to increase the padding of the select form below. Screenshot from 2021-12-15 09-01-39

garettarrowood commented 2 years ago

No worries, this looks great! Thank you for this contribution!