search

rubyforgood / inkind-admin

A project serving Community Education Partnerships - https://www.cep.ngo/ . This Rails application presents an admin interface for CEP to manage their volunteers and students. And provides a GraphQL backend for https://github.com/rubyforgood/inkind-volunteer .
MIT License
9 stars 27 forks source link

Styled De/activation Confirmations (JS Alerts) #194

Closed JelenaD1 closed 2 years ago

JelenaD1 commented 2 years ago

Resolves #155

This PR is adding a sweet alert library to style alert messages in the app.

Description

Sweetalert2 gem was added to Gemfile and package.json.

Type of change

New feature that styles the alert messages.

Screenshots

Volunteers___INKIND _volunteers_table_html_erb_—_inkind-admin
JelenaD1 commented 2 years ago

Hey @garettarrowood , me and @RudeChowder just finished adding sweet alert library. We will open a new PR and updated the pages to use sweetalert. Let us know if any changes are needed.

garettarrowood commented 2 years ago

Looks good @JelenaD1 & @RudeChowder !

Be sure to make the text in the buttons all CAPS. And see if you can get rid of the big yellow circle with the explanation mark in it.

JelenaD1 commented 2 years ago

@garettarrowood That circle is an icon and we can easily remove it. I'll update it tonight.

JelenaD1 commented 2 years ago

@garettarrowood This is done. I've updated the pages and a screenshots. I'm not sure if I need to write docs on default values- I've added info on the second screenshot for you to see it.

garettarrowood commented 2 years ago

Looks like CI got a little misconfigured recently and isn't running on PRs. I've updated the github workflow to fix this (I think). Could you pull and merge upstream master into this so CI runs?

JelenaD1 commented 2 years ago

Looks like CI got a little misconfigured recently and isn't running on PRs. I've updated the github workflow to fix this (I think). Could you pull and merge upstream master into this so CI runs?

I did pull from master beforehand. I also tried again and it says my local branch is up to date, unless I am doing it wrong.

jelenadurovic_Jelenas-MacBook-Pro___Desktop_inkind-admin
garettarrowood commented 2 years ago

Try first pulling upstream main. So first checkout your local main branch. Then git pull upstream main. Then go back to your branch. Then git rebase origin/main.

JelenaD1 commented 2 years ago

Try first pulling upstream main. So first checkout your local main branch. Then git pull upstream main. Then go back to your branch. Then git rebase origin/main.

Hey @garettarrowood , me and @RudeChowder just pull upstream and got latest from main repo. CI finally started running, BUT it looks like it failed during the setup: https://github.com/rubyforgood/inkind-admin/runs/5079900367?check_suite_focus=true

garettarrowood commented 2 years ago

Pull upstream one more time. The Azure check in CI has been removed.

JelenaD1 commented 2 years ago

Pull upstream one more time. The Azure check in CI has been removed.

Will do. Thanks @garettarrowood