improve user models specs

[gabrielbaldao]

Checklist:

• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes ("bin/rspec")
• [ ] Title include "WIP" if work is in progress

Resolves #000

Description

I trying improve the user models specs, avoid using create when could be use build, btw I have one doubt, make sense into user role, the type active have zero as value?

Type of change

Which of these options are relevant? (remove those that do not apply)

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Documentation update

How Has This Been Tested?

This is just spec improve Please describe the tests that you ran to verify your changes and instructions to reproduce.

[garettarrowood]

Thank you for contributing!

I just added these workflow actions a couple days ago, and it looks like I still need to make some adjustments to the rspec workflow.

If you push the linting fixes for the standardrb check, I will run this locally to verify the units tests are passing (and work on CI again myself).

[garettarrowood]

Thanks! And lastly. I believe I have fixed our issue with the rspec / rspec Github action. Could you merge master into this branch once more?

[garettarrowood]

^ With that said. Since you've opened this, the codebase has been renamed. And the name field on the User model has been split.

I'm receptive to adding shoulda-matchers and merging your test updates. But the path of least resistance might be opening up a new PR given the architectural changes. (I've never had an open PR against a repo that changes name. I wonder what happens?)

[garettarrowood]

Great. Thank you!