rubyforgood / inkind-admin

A project serving Community Education Partnerships - https://www.cep.ngo/ . This Rails application presents an admin interface for CEP to manage their volunteers and students. And provides a GraphQL backend for https://github.com/rubyforgood/inkind-volunteer .

MIT License

9 stars 27 forks source link

Do not allow inactive Volunteers/Admins to login #77

Closed garettarrowood closed 3 years ago

garettarrowood commented 3 years ago

Summary

As an admin, I do not want inactive users to be able to login to InKind.

Things to Consider

There are two logins. One to get into this app, the admin interface using REST. And one to get into the volunteer app, which uses GraphQL.

Criteria for Completion

[ ] When I login as an active user, everything still works as expected.
[ ] When I attempt to login as an inactive user, I am not logged in.

rimenes commented 3 years ago

I'm on it

rimenes commented 3 years ago

@garettarrowood What's the expected error message for this scenario?

garettarrowood commented 3 years ago

@rimenes - I think it'd be fine if either:

The login just didn't work (standard message that the email or password is wrong).
A message popped that said the account associated with that email/username is no longer active.