rubyforgood / pantry_scheduler

MIT License
7 stars 13 forks source link

USDA cert date needs to be an editable field for checkin #87

Closed pollygee closed 6 years ago

pollygee commented 7 years ago

When checking someone in if we re-certify them we need to be able to update the UDSA cert date.

ewiggins commented 7 years ago

@pollygee I'll take this one!

pollygee commented 7 years ago

Ok @ewiggins that's awesome! Thanks and welcome! I'll send you an invite to contribute, please assign this ticket to yourself when you accept the invite so others will know this ticket is taken. Let me know if you need more clarification on the workflow.

Here's a bit more info to get you started. Clients need to "re-certify" once a year. So if a client comes in and their certification date has passed a year ago then we need to have them sign a new paper to re-certify. There is a checkin modal when you click checkin from the dashboard. From that modal the volunteer will see that they need to sign a new paper. At that point they need to be able to update the date. We probably want this to default to today but be able to be changed (in case they had already filled out the paper on the last visit or something but the date wasn't updated - we keep the physical paper at Elizabeth House).

ewiggins commented 7 years ago

@pollygee Ok. I'll reach out if I need more clarification.

ewiggins commented 7 years ago

Hey @pollygee , I'm having some trouble getting the react to render. This is what I get when I install yarn, run ./bin/webpack-dev-server and then run rails s. Any ideas? I added 'Hello' to make sure the application.js was loading. screen shot 2017-09-14 at 7 54 15 pm

pollygee commented 7 years ago

@ewiggins that's weird I haven't seen that before. You've followed all the instructions in the README with the seed data and all that? I would try stopping and starting the servers again, and maybe even close terminal and open it again. Also do you have React Dev tools installed in your browser? If so are you seeing any react errors?

ewiggins commented 7 years ago

@pollygee Yea I've followed them all. For some reason, the react app isn't loading. I'll keep troubleshooting. Just wanted to see if you've seen this before.

screen shot 2017-09-14 at 9 50 03 pm

ewiggins commented 7 years ago

Hey @pollygee , doesn't look like the pantry wants to play nice with me :(. I unassigned myself from this issue.

jgaskins commented 7 years ago

@ewiggins Just to clarify, is that "hello" message rendered by JS?

I'd like to help you get it working if I can. Would you be up for pairing on it?

ewiggins commented 7 years ago

I would too. Would love to help out. Yep, so the application.js is rendering fine( I just placed a

Hello

in application.js to make sure it's rendering. I'm getting the console.log message as well) , but it's not picking up the React app.

When are you free to pair? I'm making a habit of working on side projects Sunday afternoon and each evening. Today and tomorrow will be hectic so my schedule will be different, but Sunday should be clear.

On Sep 15, 2017 7:53 AM, "Jamie Gaskins" notifications@github.com wrote:

@ewiggins https://github.com/ewiggins Just to clarify, is that "hello" message rendered by JS?

I'd like to help you get it working if I can. Would you be up for pairing on it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rubyforgood/pantry_scheduler/issues/87#issuecomment-329760631, or mute the thread https://github.com/notifications/unsubscribe-auth/AEeg6HoFIISm1DfuwSipx_bS0iwNJtd4ks5simVOgaJpZM4NyEJv .

jgaskins commented 7 years ago

Sure, I can do Sunday (any time's fine). Could you send a calendar invite to jgaskins@gmail.com so I don't forget? :-)

ewiggins commented 7 years ago

Done! I usually go to the Arlington Central Library during that time. Not sure where you live. Or we can do hangouts. I also have Screen Share/Slack Call.

On Sep 15, 2017 10:05 AM, "Jamie Gaskins" notifications@github.com wrote:

Sure, I can do Sunday (any time's fine). Could you send a calendar invite to jgaskins@gmail.com so I don't forget? :-)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rubyforgood/pantry_scheduler/issues/87#issuecomment-329792538, or mute the thread https://github.com/notifications/unsubscribe-auth/AEeg6F5rIa8EPyk46rtbg-3VH-MjlXdvks5sioQ8gaJpZM4NyEJv .

jgaskins commented 7 years ago

To follow up here, the issue seems to have been caused by our webpacker configuration not playing well with Cloud9. We figured out a workaround, though, and I added #112 to make it so that workaround isn't needed.

ewiggins commented 7 years ago

Sweet! I'll pull down Master.

On Sep 17, 2017 6:50 PM, "Jamie Gaskins" notifications@github.com wrote:

To follow up here, the issue seems to have been caused by our webpacker configuration not playing well with Cloud9. We figured out a workaround, though, and I added #112 https://github.com/rubyforgood/pantry_scheduler/pull/112 to make it so that workaround isn't needed.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/rubyforgood/pantry_scheduler/issues/87#issuecomment-330099605, or mute the thread https://github.com/notifications/unsubscribe-auth/AEeg6IFZeyls_t41m9S6_EkyT9vTItjyks5sjaIhgaJpZM4NyEJv .

jgaskins commented 7 years ago

It's not on master yet, but you can check out upgrade-webpack and see if it works for you. I think you'll just need to re-run bundle install and yarn install, but then rails s should work. Admittedly, I ran it on a fresh C9 instance, but it should still be good.