rubyforgood / pantry_scheduler

MIT License
7 stars 13 forks source link

enhance client endpoints, tweaks for data consistency #95

Closed ajohnson052 closed 7 years ago

ajohnson052 commented 7 years ago

This PR accomplishes several things:

Issue #17 - tests and error handling for clients endpoints

Issue #80 - counties should be restricted

Cleanup

pollygee commented 7 years ago

@ajohnson052 looks great!

My only question is that in going through creating an appointment, it looks like you can manually type information in and save an appointment. We never get an error for that but the apmt isn't saved you have to go create an client on the other tab then come back and make an appointment. Maybe this should be another ticket though and we can merge this and I'll create another ticket? What do you think?

I'm thinking that the rest of the boxes should be greyed out and not be selectable or invisible until you select a client...that way it's not confusing for non-tech people. Alternatively and maybe easier for MVP we can just flash an error message that the client doesn't exist, need to create the client before you can make an appointment for them.

Let me know what you think! Thanks for all the great work!

ajohnson052 commented 7 years ago

@pollygee - you're right, we definitely need to address the appointment creation flow, but I wasn't considering that as part of this issue.

I just created issue #96 as a placeholder for the appointment creation flow, but it still needs the description filled out