search

rubyforgood / pet-rescue

Pet Rescue is an application making it easy to link adopters/fosters with pets. We work with grassroots pet rescue organizations to understand how we can make the most impact.
MIT License
60 stars 103 forks source link

I18N - find places where we have not used I18N and add copy to en.yml #737

Open kasugaijin opened 3 months ago

kasugaijin commented 3 months ago

We started off well adding text displayed in the UI (view copy, alert messages, and active record error messages) in the I18n en.yml file, but then we got a bit forgetful.

This task is to look through the application and find cases where we should move text from a view to en.yml, a controller (e.g., alert messages), and also add copy in en.yml for active record validation error messages.

I am not specifying a set amount of work for this task as I don't know how many places this occurs. If you prefer, you can scope the work and report back, or just start making the changes and make a PR resource by resource.

wandergithub commented 3 months ago

Can I work on this issue?

jmilljr24 commented 3 months ago

@wandergithub just an fyi, in #738 which will be merged soon I added a method which you can use for translating enum's if you get to those in this issue. Let me know if you have any questions about it.

wandergithub commented 3 months ago

@kasugaijin Hi, after working and investigating this issue I've noticed that updating translations in big chunks has led to some translations being missing due to managing too much of them.

I don't know what you guys would like me to do with #791 or if you want me to continue with the views to manage to close this issue. But I've been thinking it would be better if the translations are added while working with code and changes related to them in isolated ways. Like a gradual work/progress on upcoming PRs. Now it should be easier with the rules while we reinforce the use of I18n in the reviews. I can help with that too.

kasugaijin commented 3 months ago

@wandergithub I'd say do as much as you are comfortable doing in the PR, then we can try address the rest in related work. The only issue with leaving it to other work is that it will probably be forgotten about, and there may be areas that do not get any focus for a while, if at all. But, that said, I don't want this to become uncomfortably large for you either.

wandergithub commented 3 months ago

I will wrap up my contributions to the translations with this last PR. Moving on to addressing other topics.

github-actions[bot] commented 1 month ago

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] commented 1 month ago

Automatically unassigned after 7 days of inactivity.