search

rubyforgood / pet-rescue

Pet Rescue is an application making it easy to link adopters/fosters with pets. We work with grassroots pet rescue organizations to understand how we can make the most impact.
MIT License
57 stars 95 forks source link

Rename AdopterApplication to CustomForm::Submission #823

Closed kasugaijin closed 1 month ago

kasugaijin commented 2 months ago

AdoptionApplication should be renamed to CustomForm::Submission. This means renaming all areas in the app (table (submissions), model, controller, policies, views, tests etc.). It should be a relatively straightforward find and replace.

Note the table should be renamed to submissions_table. The CustomForm scope helps to organize this resource along with others that are similar.

Any questions - comment below!

MooseCowBear commented 2 months ago

I can do this

MooseCowBear commented 2 months ago

@kasugaijin Should the methods with 'application' in their names also be renamed? What about all the variables? And the AdoptionApplicationReviewsController?

kasugaijin commented 2 months ago

@MooseCowBear yes ideally we replace all for consistency. I think search and replace should make this pretty straightforward!

kasugaijin commented 2 months ago

@MooseCowBear please nest the classes instead of inline: https://thoughtbot.com/blog/why-you-should-nest-modules-in-ruby we are trying to move to the nested format throughout.