rubyforgood / pet-rescue

Pet Rescue is an application making it easy to link adopters/fosters with pets. We work with grassroots pet rescue organizations to understand how we can make the most impact.

MIT License

57 stars 95 forks source link

Dockerize Pet Rescue #824

Closed kasugaijin closed 1 month ago

kasugaijin commented 2 months ago

Dockerizing the app to help lower the barrier to getting up and running for contributors. I opted to just use a dockerfile with docker-compose and rely on docker commands to get up and running - not using a devcontainer for now (I do not use VSCode).

With these changes so far, the app works as expected in Docker. However:

System tests are failing still. I added Chromium to the base image, but now getting a ferrum timeout error.
I was having asset delivery issues, so I run the command to precompile assets, though I know this can slow boot times down a bit
What would be ideal to include in a dockerignore file?

🔗 Issue

✍️ Description

📷 Screenshots/Demos

cflipse commented 2 months ago

Also, you really probably want to also have the docker container launch the javascript / assets process as well. The line in the Procfile that looks like: css: bin/rails dartsass:watch

basically, if you're running a full docker-compose container, you can fully avoid using the Procfile structure (foreman is quite a bit older than docker, and can be supplanted, it turns out)

That may also address what you were seeing and trying to address with the asset precompile, but there may be some port-mapping things to wrangle....

kasugaijin commented 2 months ago

css: bin/rails dartsass:watch

Ah right thank you for catching that. I have added a SASS container.

kasugaijin commented 2 months ago

@cflipse So I think this is good to go for now until we need to consider configration for deployments, right? I added some instructions for setting up local dev environment to the readme.

kasugaijin commented 1 month ago

@cflipse bump