search

rubyforgood / pet-rescue

Pet Rescue is an application making it easy to link adopters/fosters with pets. We work with grassroots pet rescue organizations to understand how we can make the most impact.
MIT License
57 stars 95 forks source link

Rename DefaultPetTask to Checklist::TaskTemplate #834

Open kasugaijin opened 2 months ago

kasugaijin commented 2 months ago

DefaultPetTask should be renamed to Checklist::TaskTemplate. This means renaming all areas in the app (table (default_pet_tasks), model, controller, policies, views, tests, variables, methods etc.). It should be a relatively straightforward find and replace.

Note the table should be renamed to task_templates_table. The Checklist scope helps to organize this resource along with others that are similar.

please nest the classes instead of inline: https://thoughtbot.com/blog/why-you-should-nest-modules-in-ruby we are trying to move to the nested format throughout.

Any questions - comment below!

ErinClaudio commented 2 months ago

@kasugaijin can I take this one?

kasugaijin commented 2 months ago

@ErinClaudio all yours

ErinClaudio commented 2 months ago

@ben @mononoken I have a couple of things that are going to keep me busy and unable to work on this until Wednesday. I am happy to start this then but I do not want to block anyone else's work. please feel free to give this away if needed

kasugaijin commented 2 months ago

OK, I will unassign now and if it's free on Wed pick it up! @ErinClaudio

ErinClaudio commented 1 month ago

Ok - I can do this one now @kasugaijin

ErinClaudio commented 1 month ago

https://gist.github.com/ErinClaudio/b43b9dc0906faba2f1be742576726825

github-actions[bot] commented 3 weeks ago

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] commented 2 weeks ago

Automatically unassigned after 7 days of inactivity.