search

rubyforgood / pet-rescue

Pet Rescue is an application making it easy to link adopters/fosters with pets. We work with grassroots pet rescue organizations to understand how we can make the most impact.
MIT License
57 stars 95 forks source link

Move pet image in the staff pets show pages #862

Open mononoken opened 1 month ago

mononoken commented 1 month ago

Description

tl;dr: We want to remove the right side image from the staff pets show page and add a thumbnail in its place to the header of the page.

We have received negative feedback from developers in regards to the image found on the staff pets show page. Currently, this page has multiple tabs for staff to navigate through for a pet. There is an image of the pet to the right.

Many of these tabs could be reusing partials from other pages. However, those partials in other locations do not have this image, and so we end up having to redesign a partial to be used for multiple pages but with different width constrictions. The image does not serve any particular benefit either other than helping signal to staff which pet they are looking at currently.

We want to remove the image, add a thumbnail, and we also need to adjust some of the html/css here. With the image removed, we will want the content of the page to take up the space that the image used to occupy. That way, we can share partials from other pages and they will have the same space constraints.

We also may need to adjust the html to allow for the thumbnail to exist as shown in the screenshot.

And finally, make sure the layout still works well for mobile.

Image

https://www.figma.com/design/0jVgYASUJy0KiX3BVc3dFM/Tasks?node-id=1094-70&t=WZjsRcM8EoT4DZdu-1 Note: Ignore the content in the box; this PR is only concerned about the thumbnail Image

Acceptance Criteria

Aaryanpal commented 1 month ago

Hi @mononoken I can take up this issue. Can you please assign it to me? Thanks

jmilljr24 commented 1 month ago

@Aaryanpal All yours! Let us know if you have any questions.

kasugaijin commented 1 month ago

How's this doing @Aaryanpal ?

kasugaijin commented 1 month ago

bump @Aaryanpal need any help on this?

Aaryanpal commented 1 month ago

I will be working at @kasugaijin today. I apologize for the delay; I was traveling to a new city, which took some time. I'll update you on my progress tomorrow. Thank you for your understanding.

kasugaijin commented 4 weeks ago

@Aaryanpal thanks for the update! No rush at all. Take your time. I just like to make sure people are still interested otherwise I like to reassign.

Aaryanpal commented 4 weeks ago

@kasugaijin Thanks for Understanding.