Logged-in users can pledge items

rubyforgood / playtime

Supporting children and families experiencing homelessness in Washington, DC. Live app - https://wishlist.playtimeproject.org Organization Website:

http://www.playtimeproject.org/

MIT License

89 stars 50 forks source link

Logged-in users can pledge items #108

Closed leesharma closed 7 years ago

leesharma commented 7 years ago

Resolves #93

user_pledging_demo

Apparently I'm sending DC General a ton of corgis.

d3f7bad isn't actually required because I didn't end up adding PhantomJS tests, but it still makes the console error go away.

d20ffb3 may or may not be acceptable; I'm cutting corners (in terms of testing especially) in order to get this done. Let me know if you think this could use some more work.

leesharma commented 7 years ago

I created a review app so you can see it in action. Be sure to log in–the guest pledging isn't implemented in this PR!

micahbales commented 7 years ago

I think the weaknesses you've identified are acceptable for now. Once we've got the MVP launched, it may make sense to revisit.