search

rubyforgood / playtime

Supporting children and families experiencing homelessness in Washington, DC. Live app - https://wishlist.playtimeproject.org Organization Website:
http://www.playtimeproject.org/
MIT License
89 stars 50 forks source link

Add PR template #124

Closed leesharma closed 7 years ago

leesharma commented 7 years ago

(Falls under #113)

We've got an influx of new people, so adding a pull request template should help the review process. For reference, a PR template will be shown whenever someone opens a PR, and it can serve as a guide for what we expect to see. The template contains a checklist of the basic elements of a PR (ex. the Resolves # line).

One possibly controversial decision: since I was putting the PULL_REQUEST_TEMPLATE.md into the .github folder, I went ahead and moved CONTRIBUTING.md there too. On the plus side, it helps declutter the root and keeps these files that GitHub uses together. On the downside, CONTRIBUTING.md is no longer at the root.

Let me know if you disagree with that decision, the PR template, or anything else.

leesharma commented 7 years ago

I'm going to do an awful thing and self-merge this. 😬

We're getting a pretty big influx of people. Since I'm doing the PR reviewing, I'm claiming executive privilege.