Improving seed data - Githubissues

rubyforgood / playtime

Supporting children and families experiencing homelessness in Washington, DC. Live app - https://wishlist.playtimeproject.org Organization Website:

http://www.playtimeproject.org/

MIT License

89 stars 50 forks source link

Improving seed data #159

Closed yock closed 7 years ago

yock commented 7 years ago

Resolves #157

Description

Seeds data for Several wishlists, including site managers, real data for 20 Amazon products, and some owned and anonymous pledges.

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Existing test suite passes. My own testing consisted of running the seeds, running the app, browsing and clicking through to products, and clicking through to create new pledges.

Screenshots

yock commented 7 years ago

@leesharma After inverting the assignment loop I still see duplicates on the home page of the site when I run it locally. Would this be expected if an items appears in multiple wishlists? If so, might this be desired behavior or a bug?

leesharma commented 7 years ago

@yock I see what you mean. The seeds have the desired behavior, but we'll definitely need to address that in the UI. I'll add a separate issue for that.

This looks good to me! :+1: Any other changes you want to make, or is this ready to merge?

yock commented 7 years ago

@leesharma It's ready from my perspective. 👍

leesharma commented 7 years ago

Perfect–thank you! I especially appreciated the astronauts. 🚀