[WIP] added friendly id gem, updated controller for friendly, updated model…

rubyforgood / playtime

Supporting children and families experiencing homelessness in Washington, DC. Live app - https://wishlist.playtimeproject.org Organization Website:

http://www.playtimeproject.org/

MIT License

89 stars 52 forks source link

[WIP] added friendly id gem, updated controller for friendly, updated model… #160

Closed reneesandefur closed 6 years ago

reneesandefur commented 6 years ago

… with extend friendly id and paramats for updating slug

Incorporated friendly id for slug, working locally, still working on writing tests

Resolves #156

Description

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Documentation update

How Has This Been Tested?

Screenshots

seanmarcia commented 6 years ago

Hey @reneesandefur thanks for the PR! Looks like you haven't added tests and updated the current tests to reflect friendly_id yet (which is why CI is failing.) Do you have a plan for that?

reneesandefur commented 6 years ago

Hi,

Sorry crazy couple weeks but I should be able to have it done before Friday

On Nov 3, 2017 8:26 PM, "Sean Marcia" notifications@github.com wrote:

Hey @reneesandefur https://github.com/reneesandefur thanks for the PR! Looks like you haven't added and updated tests to reflect friendly_id yet. Do you have a plan for that?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rubyforgood/playtime/pull/160#issuecomment-341857614, or mute the thread https://github.com/notifications/unsubscribe-auth/AZIPo60mpjtEWKqB3IyxkoSmq6veYrGhks5sy680gaJpZM4QCP8I .

leesharma commented 6 years ago

Since there hasn't been development on this branch in a few months, I'm going to close the PR. Let me know if you want me to re-open it!