Custom Error Pages - Githubissues

rubyforgood / playtime

Supporting children and families experiencing homelessness in Washington, DC. Live app - https://wishlist.playtimeproject.org Organization Website:

http://www.playtimeproject.org/

MIT License

89 stars 50 forks source link

Custom Error Pages #191

Open nico24687 opened 6 years ago

nico24687 commented 6 years ago

Resolves #123

Description

Based off of work done by @admir23 in #130.
Addresses concerns from @leesharma (https://github.com/rubyforgood/playtime/pull/130#issuecomment-337460393) by removing the application layout from the error pages.
Updated error messages to correspond to the particular status code (404, 422, 500)
Updated ErrorController specs to pass

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally by hitting /404.html , /422.html, /500.html
Ran the specs and all pass

Screenshots

screen shot 2018-03-27 at 19 57 49