search

rubyforgood / playtime

Supporting children and families experiencing homelessness in Washington, DC. Live app - https://wishlist.playtimeproject.org Organization Website:
http://www.playtimeproject.org/
MIT License
89 stars 50 forks source link

social media sharing from wishlist page #88

Closed Brennaleker closed 7 years ago

Brennaleker commented 7 years ago

screen shot 2017-08-04 at 10 16 51 pm I chose email, Facebook and Twitter as sharing options but more can be found here

leesharma commented 7 years ago

:+1: That looks really nice so far! I love how the colors seem to match the app.

Those options make sense to me, but that might be something to ask the client about when we show them the app–they might have some other favorites.

micahbales commented 7 years ago

This looks good to me, too. What are the next steps in completing this feature, @Brennaleker?

Brennaleker commented 7 years ago

@micahbales the functionality works as expected locally but when I looked at the changes on the staging site I noticed that while the icons are there the onclick functionality is not due to JS throwing an UncaughtReferenceError "SocialShareButton is not defined". I'd like to dig into that before merging. I should have some time tonight or tomorrow night to look into it.

micahbales commented 7 years ago

Sounds good! Thanks, Brenna.