I used rubocop (version 0.41.2, some minor version bumps change default rules) to clean up the code a bit.
I don't feel too strongly about any specific cop, but I think consistency across the code base is biggest win rubocop provides.
This uses the default cops with two exceptions:
I disabled the Style/Documentation cop, which gives warnings if a documentation style comment isn't added above each class
I set the default line length to 100. I feel 80 is a difficult bar to get to, especially with class names like OrganizationCampaign and rails find_by_organization_id_and_campaign_id style finders.
The first commit on this PR includes the majority of the work. those changes were generated with rubocop --autocorrect. This fixes a lot of style warnings for you. the 65 changed files may put you off to reviewing, so I'd recommend looking at this commit by commit, without concentrating on autocorrected fixes.
I used rubocop (version 0.41.2, some minor version bumps change default rules) to clean up the code a bit.
I don't feel too strongly about any specific cop, but I think consistency across the code base is biggest win rubocop provides.
This uses the default cops with two exceptions:
OrganizationCampaignand railsfind_by_organization_id_and_campaign_idstyle finders.The first commit on this PR includes the majority of the work. those changes were generated with
rubocop --autocorrect. This fixes a lot of style warnings for you. the 65 changed files may put you off to reviewing, so I'd recommend looking at this commit by commit, without concentrating on autocorrected fixes.