[WIP] Kickstart recipient reports

rubyforgood / share_christmas

Share Your Holiday Application

4 stars 3 forks source link

[WIP] Kickstart recipient reports #116

Closed atzorvas closed 8 years ago

atzorvas commented 8 years ago

Pending:

[x] recipients_controller_spec.rb
[x] invoke window.print when requesting the page with print format
[ ] refactor RecipientsController once the following are merged: #107

AEgan commented 8 years ago

I've just skimmed over the code, but wanted to bring up that the match model and table are going to be deleted when I get around to rebasing #107. In practice the membership / recipient relationship in our app was being treated as one membership has many recipients, so we are going to change the database and relationships to reflect that and drop the complexity added by the join model.

atzorvas commented 8 years ago

@AEgan what ETA do you think #107 has?

I could follow your PR in order for this feature to be ready-for-merge right after #107 is merged into master.

AEgan commented 8 years ago

I'll try to get that done after work today. I'll let you know when it gets merged. Thanks!

craig-riecke commented 8 years ago

Master diverged too far, so copied these changes into #155.