rubyforgood / share_christmas

Share Your Holiday Application
4 stars 3 forks source link

RecipientFamily should belong to a campaign #131

Closed atzorvas closed 7 years ago

atzorvas commented 8 years ago
atzorvas commented 8 years ago

Blocks #130

AEgan commented 8 years ago

(edited the wrong pr, move along...)

craig-riecke commented 7 years ago

Finished this. It's the recipient family that should be assigned to the campaign, not the recipient. Added some comments to model as well to make that association clear.

I also removed the org_campaign link in the recipient ... it is redundant with the one in the recipient_family. That makes some methods more complicated, but not terribly so.