search

rubyforgood / share_christmas

Share Your Holiday Application
4 stars 3 forks source link

Remove ActiveAdmin #133

Closed atzorvas closed 8 years ago

atzorvas commented 8 years ago

Implements #132

AEgan commented 8 years ago

👏 👏 Love the Red PRs

We can also remove activeadmin and active_skin from the Gemfile

It's probably better to create a migration to drop the activeadmin tables instead of deleting the migrations that create them, but at this stage I'm not sure we need to be super careful with database changes

atzorvas commented 8 years ago

@AEgan I could go with restoring the migrations and adding a removing one.

Though if we don't have this deployed somewhere already, maybe I would keep it as it is. I'm ok with both

AEgan commented 8 years ago

I deployed it to Heroku during ruby for good to make sure we had everything set up to be able to deploy. I/we haven't been actively deploying with every merge and keeping a production environment up to date

atzorvas commented 8 years ago

@AEgan reverted the migrations.

We had one to create an active_admin_comments table, and one to remove it so it seems that we don't have to introduce another one.

atzorvas commented 8 years ago

@AEgan I think this should be good to go now /cc @craig-riecke

craig-riecke commented 8 years ago

👍 I agree - red PR's are good! Thanks @atzorvas. Merging...