search

rubyforgood / shelter-assist

Software to help foster-based animal rescues keep track of their animals and people.
14 stars 13 forks source link

Move fields to Homes table #26

Closed chriszimmerman closed 3 years ago

chriszimmerman commented 3 years ago

I did this as a first step to make sure I'm on the right track before moving the transportation, home type, and available during the day fields over to the Homes table as well.

A few other things:

  1. I had to add the rexml gem to get my tests to start passing. I was wondering if I had environment issues, but with this gem, the tests are passing.
  2. I got rid of the extra "available during the day" field from the UI.
  3. I removed the post endpoint for homes, because I don't think we would create them in any other way at the moment, right? A home gets created when a foster signs up. I can't think of a reason to create a home by itself. We'd definitely want to update information about it, but creating new ones only happens upon signup.
  4. I got a security vulnerability warning for the nokogiri gem. I think the rexml gem depends on that. Is there anything we can do to remediate that?
  5. In general, I want to make sure I'm doing things the right way and am not adding anything here unnecessarily.

UI for reference:

image
chriszimmerman commented 3 years ago

Temporarily closing to re-open. Testing GH Slack integration