rubyforgood / voices-of-consent

Open source tracking and inventory management application for nonprofit, Voices of Consent (Ruby for Good 2019)
https://voices-of-consent.herokuapp.com
MIT License
38 stars 82 forks source link

/requesters/new not showing the correct errors #399

Open Joao-Quaresma opened 4 years ago

Joao-Quaresma commented 4 years ago

When all required fields are populated and one of them has incorrect data the form shows an email error instead of the correct errors.

This is happening due to https://github.com/rubyforgood/voices-of-consent/blob/71e627f0a324084bf43b32084712ba1b319cf7b4/app/javascript/src/components/box-request-form/BoxRequestForm.js#L245

Replicate steps:

maebeale commented 4 years ago

THANK YOU, @Joao-Quaresma !

MatthewBosek commented 4 years ago

Can I get to work on this one please? :D

maebeale commented 4 years ago

Sure can, @MatthewBosek !

MatthewBosek commented 4 years ago

Hey just want to give a quick update. The log correctly captures the error, but functionality does not reflect. Continuing to investigate. PostSendClick

maebeale commented 4 years ago

@MatthewBosek hello there! any updates on this issue? do you plan to still work on it?