search

rubyfu / RubyFu

Rubyfu, where Ruby goes evil!
http://rubyfu.net
333 stars 103 forks source link

references removed #50

Closed noraj closed 3 years ago

noraj commented 3 years ago

In https://github.com/rubyfu/RubyFu/commit/501ed360acea4e6f768ec5b755b055cffc4c5a73 references.md was removed by error, so this gives us a 404: https://rubyfu.net/references

noraj commented 3 years ago

PS only the first 3000 files are displayed on the PR on github of the 4,570 files changed. as node_mobules is alphabetically before references.md we don't see it on the list, you have to check on the CLI.

KINGSABRI commented 3 years ago

Omg, @SidWorks there are some issues in your PR. You have deleted markdown files

KINGSABRI commented 3 years ago

@noraj thanks man for noticing this issue, we can upload it again. I've created a backup branch before accepting #48 PR. I was really skeptical about it

noraj commented 3 years ago

@noraj thanks man for noticing this issue

I'm like the watch tower of this project 😂

KINGSABRI commented 3 years ago

Yes you are :D . Really nice catch!

noraj commented 3 years ago

I've created a backup branch before accepting #48 PR. I was really skeptical about it

no need for a backup branch, a git commit can easily be reverted

noraj commented 3 years ago

by the way this page was remvoed too https://rubyfu.net/required-gems, I'm fixing it all

noraj commented 3 years ago

@KINGSABRI maybe you could add me to the project and set me as default reviewer (even if I don't have the permission to merge PRs)

noraj commented 3 years ago

@KINGSABRI Why did you reverted the revert that I made to fix the removed markdown files (https://github.com/rubyfu/RubyFu/commit/babc7ea4bb92642d90407d3ca63c5fbdb9df0733)? Because you re-removed them 😂

KINGSABRI commented 3 years ago

It was a bad move by a sleepy guy

noraj commented 3 years ago

It was a bad move by a sleepy guy

so should I re-re-revert it or you're doing it?

SidWorks commented 3 years ago

Omg, @SidWorks there are some issues in your PR. You have deleted markdown files

Apologies @KINGSABRI 🙏 I did the commit without installing npm packages, I guess that what caused the issue. image

Some files are missing because of that! I didn't not deleted or removed anything. I am extremely sorry for this. It can be fixed easily with next commit to a PR. Please let me know on this 🙏

KINGSABRI commented 3 years ago

It was two sides mistakes. Deleting a huge number of files was hard to review with the limited time I have.

I believe @noraj is working on it already, he's got sharp eyes