search

rubygems / bundler

Manage your Ruby application's gem dependencies
https://bundler.io
MIT License
4.88k stars 1.99k forks source link

Delay appending `ruby/<ABI_VERSION>` to `$BUNDLE_PATH` #7501

Closed deivid-rodriguez closed 4 years ago

deivid-rodriguez commented 4 years ago

What was the end-user problem that led to this PR?

The problem was that https://github.com/bundler/bundler/pull/7163 broke several things regarding official docker ruby images.

What was your diagnosis of the problem?

My diagnosis was that appending ruby/<ABI_VERSION> to $BUNDLE_PATH break things there because gems nor executables are no longer installed at a location that rubygems now about.

What is your fix for the problem, implemented in this PR?

My fix is to revert the offending PR for the time being.

Why did you choose this fix out of the possible options?

I chose this fix because it's quick.

I think the better fix would be to get BUNDLE_PATH__SYSTEM=true working as expected and upstream that change to the docker images, because I think that's exactly the use case for the docker images. But I need more time for that, and I want to restore working behavior.

/cc @indirect Sorry, you were right about this being dangerous :flushed:

Closes #7197. Closes #7494.

indirect commented 4 years ago

@bundlerbot r+

ghost commented 4 years ago

Build failed

deivid-rodriguez commented 4 years ago

Let me get this green first :sweat_smile:.

indirect commented 4 years ago

whoops 😅

jimeh commented 4 years ago

Just an FYI, but this PR does fix issue #7494 which I reported. Proof is in this comment.

deivid-rodriguez commented 4 years ago

We will keep this bug fix in the end since things were fixed in the docker side in the end, so closing.