search

rubygems / bundler

Manage your Ruby application's gem dependencies
https://bundler.io
MIT License
4.88k stars 1.99k forks source link

Fix `rake build` when path has spaces on it #7514

Closed deivid-rodriguez closed 4 years ago

deivid-rodriguez commented 4 years ago

What was the end-user problem that led to this PR?

The problem was that rake build can no longer be run from a path that has spaces on it.

What was your diagnosis of the problem?

My diagnosis was that we need to escape the path for the shell somewhere.

What is your fix for the problem, implemented in this PR?

My fix is to add .shellescape at the right place.

Why did you choose this fix out of the possible options?

I chose this fix because it fixes the problem.

Fixes #7512.

deivid-rodriguez commented 4 years ago

@bundlerbot r=colby-swandale

ghost commented 4 years ago

Build succeeded