Remove usused code and simplify concat method - Githubissues

rubygems / bundler

Manage your Ruby application's gem dependencies

https://bundler.io

MIT License

4.88k stars 1.99k forks source link

Remove usused code and simplify concat method #7558

Closed larskanis closed 4 years ago

larskanis commented 4 years ago

The unused code is a leftover from commit 38b0e7ed64c3ca1c40f43c5aa9a1ead2f6cd7049 . That commit disabled that RubyVersion.system is respected, but it seems that that feature wasn't missed.

What was the end-user problem that led to this PR?

Not known.

What was your diagnosis of the problem?

I read the bundler source code and noticed this.

What is your fix for the problem, implemented in this PR?

My fix removes the code that seems to be of no use.

Why did you choose this fix out of the possible options?

As a alternative I added #7559 that reactivates the code in question.

deivid-rodriguez commented 4 years ago

Went ahead with the other PR, so closing. Thanks @larskanis!