search

rubygems / bundler

Manage your Ruby application's gem dependencies
https://bundler.io
MIT License
4.88k stars 1.99k forks source link

Lock rack to 2.0.8 for tests #7565

Closed deivid-rodriguez closed 4 years ago

deivid-rodriguez commented 4 years ago

What was the end-user problem that led to this PR?

The problem was CI is failing due to a rack warning.

What was your diagnosis of the problem?

My diagnosis was that our CI shouldn't break because of third party changes.

What is your fix for the problem, implemented in this PR?

My fix is to lock the rack version our tests use.

Why did you choose this fix out of the possible options?

I chose this fix because it gives us a more deterministic test environment, which is good.

deivid-rodriguez commented 4 years ago

@bundlerbot merge

ghost commented 4 years ago

Build failed

deivid-rodriguez commented 4 years ago

@bundlerbot retry

ghost commented 4 years ago

Build failed

deivid-rodriguez commented 4 years ago

@bundlerbot retry

ghost commented 4 years ago

Build succeeded