search

rubygems / bundler

Manage your Ruby application's gem dependencies
https://bundler.io
MIT License
4.88k stars 1.99k forks source link

Update references to old repo location #7577

Closed duckinator closed 4 years ago

duckinator commented 4 years ago

Related: #7572.

What was the end-user problem that led to this PR?

A lot of things use the outdated https://github.com/bundler/bundler URL (and similarly for e.g. bundler/bundler-site).

What is your fix for the problem, implemented in this PR?

My fix was to update the outdated URLs. :slightly_smiling_face:

TODO

duckinator commented 4 years ago

I'm leaning towards keeping functional changes out of this PR, and have each functional change be its own PR. It seems like it would be far easier to review.

Current state of this PR:

  1. There's a reference to a pullreview.com URL. This service hasn't existed since 2018, as best I can tell. Not sure how to update that section.
  2. No functional changes have been made. Only documentation, a message in .github/config.yml, comments, and skip "..." messages (in spec/), and things of that sort.
  3. I've avoided CHANGELOG.md for now because that will just absolutely dominate the PR. It may make sense to have that be a separate PR just due to the size of it.
duckinator commented 4 years ago

cc @deivid-rodriguez

duckinator commented 4 years ago

lmao how the heck did this cause a test failure?! that makes no sense at all.

https://github.com/rubygems/bundler/pull/7577/checks?check_run_id=394415562#step:5:1716

deivid-rodriguez commented 4 years ago

@duckinator Definitely not this PR's fault. It sounds like a parallelization-related flaky. I'll look into it. Is this one ready to merge?

duckinator commented 4 years ago

Just went through and:

@deivid-rodriguez I'll remove the reference to pullreview.com, as you said to in #7579, and then it'll be ready. I'll save the functional changes for separate, smaller pull requests.

duckinator commented 4 years ago

@deivid-rodriguez this is ready to merge! I've avoided making functional changes in this PR. I couldn't get ronn to work right, so I left the man page alone as well.

duckinator commented 4 years ago

Hmm, that test which should in no way be affected by this PR is still causing problems.

deivid-rodriguez commented 4 years ago

It should be ok now, thanks @duckinator!

@bundlerbot merge

ghost commented 4 years ago

Build succeeded