rubygems / bundler

Manage your Ruby application's gem dependencies
https://bundler.io
MIT License
4.88k stars 2k forks source link

Improve OpenSSL load failure message #7596

Closed deivid-rodriguez closed 4 years ago

deivid-rodriguez commented 4 years ago

In #7527 we improved the message to show underlying error and backtrace.

However, we should also improve the other part of the message, namely:

You must recompile Ruby with OpenSSL support or change the sources in your Gemfile from 'https' to 'http'. Instructions for compiling with OpenSSL using RVM are available at https://rvm.io/packages/openssl.

This message doesn't add much value, so we should remove it entirely or maybe change it to something along the lines of:

Could not load OpenSSL, you ruby might not be compiled with OpenSSL support. The underlying error was #{error.class}: #{error}\n#{error.backtrace.join("\n ")}"

The reason is:

Originally posted by @deivid-rodriguez in https://github.com/rubygems/bundler/pull/7527

deivid-rodriguez commented 4 years ago

This was completely fixed by https://github.com/rubygems/bundler/pull/7597, so closing.