search

rubygems / bundler

Manage your Ruby application's gem dependencies
https://bundler.io
MIT License
4.88k stars 2k forks source link

Fix config location edge case #7622

Closed deivid-rodriguez closed 4 years ago

deivid-rodriguez commented 4 years ago

What was the end-user or developer problem that led to this PR?

The problem was that if BUNDLE_APP_CONFIG is set to an absolute path, and there's no Gemfile up in the directory hierarchy, bundler would end up using the default config location instead of the customized one.

What is your fix for the problem, implemented in this PR?

My fix is to completely avoid bundler's root resolution for resolving the config path in this case, since BUNDLE_APP_CONFIG includes all the information we need to know.

Fixes #7610.

deivid-rodriguez commented 4 years ago

@bundlerbot merge

ghost commented 4 years ago

Build failed

deivid-rodriguez commented 4 years ago

@bundlerbot retry

ghost commented 4 years ago

Build succeeded