search

rubygems / release-gem

The official GitHub Action for publishing your gem files to RubyGems.org
23 stars 2 forks source link

Compare string value `true` #4

Closed jgarber623 closed 11 months ago

jgarber623 commented 11 months ago

GitHub Actions booleans aren't… really… booleans.

See: https://github.com/actions/runner/issues/1483

I tripped on this here with a configuration like:

- uses: rubygems/release-gem@v1
  with:
    await-release: false

This configuration is valid, but is ignored owing to the current configuration. This proposed change should address that.

The proposed change is consistent with behavior in other reusable actions (see ruby/setup-ruby, for instance).

jgarber623 commented 11 months ago

Thanks for the merge, @segiddins!

jgarber623 commented 10 months ago

Posting here to confirm that this change did what we hoped it would do! A workflow file using this step:

- uses: rubygems/release-gem@v1
  with:
    await-release: false

…successfully skipped the gem exec command (see logs).