search

rubygems / rfcs

RubyGems + Bundler RFCs
45 stars 40 forks source link

Add RFC proposal for adding bundle fund #23

Closed gjtorikian closed 4 years ago

gjtorikian commented 4 years ago

This is an RFC for the suggestion proposed in https://github.com/rubygems/rfcs/issues/22: adding a bundle fund command which shows information about any gems requiring funding. I look forward to hearing any feedback!

olleolleolle commented 4 years ago

Is there a specific reason why funding_uri is not a part of the metadata?

gjtorikian commented 4 years ago

Is there a specific reason why funding_uri is not a part of the metadata?

I never knew about this attribute before. It certainly makes sense to add there as well.

olleolleolle commented 4 years ago

You can read more details about this "sandboxed, freeform" hash of URIs, in the Specification source code: https://github.com/rubygems/rubygems/blob/master/lib/rubygems/specification.rb#L365

gjtorikian commented 4 years ago

Ok, I've made a quick change to the RFC to note that this key should go in the metadata attribute.

olleolleolle commented 4 years ago

(Glad you liked it. Perhaps it reduces friction!)

gjtorikian commented 4 years ago

I do believe so, especially since it matches https://github.com/rubygems/rubygems/pull/3060

gjtorikian commented 4 years ago

Is there anything I can do here to move this along?

indirect commented 4 years ago

I’m in favor of this, but I’d like to give the rest of the team a chance to weigh in. Let’s give it 3 more days and then accept if no new comments arrive. 👍🏻

colby-swandale commented 4 years ago

This has been open to comment for enough time i think and we're in favor of the RFC. Accepted.