rubygems / rubygems.org

The Ruby community's gem hosting service.
https://rubygems.org
MIT License
2.33k stars 918 forks source link

Sponser logos in footer, botton row and website redirects doesn't match on rubygems.org #2535

Closed sahilister closed 4 years ago

sahilister commented 4 years ago

Steps to Reproduce

  1. Open https://rubygems.org/
  2. In footer, sponsor section, click on bottom row sponsor logos.

Expected Behavior

  1. "gauges" logo should redirect to https://get.gaug.es/ (taken from https://guides.rubygems.org)
  2. "Runscope" logo should redirect to https://www.runscope.com/
  3. "fastly" logo should redirect to https://www.fastly.com/
  4. "DataDog" logo should redirect to https://www.datadoghq.com/
  5. "Travis CI" logo should redirect to https://travis-ci.org/
  6. If honeybadger is still a sponsor, a logo of that should be present.

Current Behavior

1."gauges" logo, redirect to https://www.runscope.com/

  1. Click on "Runscope" logo, redirects to https://www.fastly.com/
  2. Click on "fastly" logo, redirects to https://www.datadoghq.com/
  3. Click on "DataDog" logo, redirects to https://travis-ci.org/
  4. Click on "Travis CI" logo, redirects to https://www.honeybadger.io/

Possible Solution

Environment

Browser and its version: Mozilla Firefox 78.3.0esr (64-bit), Brave Browser 1.15.75 Chromium: 86.0.4240.99 (Official Build) (64-bit) RubyGems version: Not applicable.

Additional Context

Sponser logo on https://blog.rubygems.org/ and https://guides.rubygems.org/ displays correctly.

simi commented 4 years ago

I can confirm it is shifted.

Current approach is hardcoded in sponsors.png (contains sprite based logos). It will be nice to get this somehow automated.

https://github.com/rubygems/rubygems.org/blob/259a9f90d5fca3e87c3bae3c11d82eb18f580d19/app/assets/stylesheets/modules/footer.css#L77-L153

samdenty commented 1 year ago

this is broken still @sonalkr132 @simi

simi commented 1 year ago

this is broken still @sonalkr132 @simi

Can you provide more details? What's wrong currently?

samdenty commented 1 year ago

the urls are stilll mixed up

simi commented 1 year ago

@samdenty can you be please more specific? Which urls where exactly?

hsbt commented 1 year ago

@simi The all of logs are incorrect link after RubyTogether.

Screenshot 2023-03-02 at 8 36 49

see down of left url. It's RubyTogether link.