Closed martinemde closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.04%. Comparing base (
1ab1c8c
) to head (bf589fd
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Extracted from
MultifactorAuthsController
and contains no code or behavior changes, just moved code.This seems worth doing because it simplifies a complex controller that has no overlap in behavior and no shared code. In the new controller we only do TOTP create and destroy, while
MultifactorAuthsController
now does just recovery and mfa levels.This also mirrors the organization of Webauthn creation.
In a follow-up PR, I'd suggest created a landing page for
/multifactor_auth/new
that gives both TOTP and WebAuthN as options on the same page. Currently this is only presented on/settings/edit
but we direct people to the page that's only useful for creating a TOTP.