search

rubygems / rubygems

Library packaging and distribution for Ruby.
https://rubygems.org/
Other
3.68k stars 1.75k forks source link

Updates needed to util/ci (Travis)? #2368

Closed MSP-Greg closed 6 years ago

MSP-Greg commented 6 years ago

Just checking test setup on Appveyor & Travis. Should any of the following be updated, re minitest (v?), bundler (1.16.3), & Robocop (0.58.2)?

https://github.com/rubygems/rubygems/blob/7bbd0dec854f869c44fce58063ca5f4161d9154f/util/ci#L52-L60

This issue is related to:

Here are my current environment details:

$ gem env version
NA

I will abide by the code of conduct.

segiddins commented 6 years ago

They could be, there just pinned to make sure there's no unexpected breakage

MSP-Greg commented 6 years ago

@segiddins

I should have been clearer. Since f1eb3b83, there isn't a need to use older version of mintest.

Re minitest, RG's CI is mostly using whatever Appveyor and Travis have installed.

Maybe the question should have been - should Travis & Appveyor CI scripts be updated so both are using the same (and newer) versions of needed gems?

I'm biased towards latest/greatest; I don't know what others think...

segiddins commented 6 years ago

Maybe the question should have been - should Travis & Appveyor CI scripts be updated so both are using the same (and newer) versions of needed gems?

ah in that case, sure!

MSP-Greg commented 6 years ago

I'll run tests on my fork with Appveyor & Travis. Not tonite.

duckinator commented 6 years ago

Would doing what rake setup does and having it install the dependencies from rubygems-update.gemspec work?

https://github.com/rubygems/rubygems/blob/8ceb7cacc87fb9c69c8cc3f946495abbd1778c5a/Rakefile#L13-L20

segiddins commented 6 years ago

I think it should!

duckinator commented 6 years ago

@segiddins in that case: should it call rake setup directly, or does rake setup relying on rake bundler:checkout make it not usable as-is? (that's an easily-adjusted thing, i just don't know whether or not it's a problem.)

segiddins commented 6 years ago

Should be fine to call it directly, give it a try? If it doesn’t work, we can figure something out

MSP-Greg commented 6 years ago

Reviewing this, there are some issues with the Travis builds, related to bundler & (missing) bundled gems...

I'll try to keep an eye on whether Travis improves the situation, as I've opened issues there. Then there's the issue of whether to test with released or updated dependencies...

Closing...