search

rubyide / vscode-ruby

Provides Ruby language and debugging support for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=rebornix.Ruby
MIT License
1.26k stars 285 forks source link

Pass valid filenames to formatter RuboCop #825

Open senhalil opened 2 years ago

senhalil commented 2 years ago

Closes rubyide#227.

Description of change and why it was needed here

github-actions[bot] commented 2 years ago

This PR has not had activity for 30 days. It will be automatically closed in 30 days.

senhalil commented 2 years ago

Can I get a review for this PR please?

Buzzkill-McSquare commented 2 years ago

Can you add test steps or suggest file names that assert that the change sticks? I can't approve but I could test and confirm that it's working.

senhalil commented 2 years ago

Thanks for the suggestion @Buzzkill-McSquare

This PR is basically a replication of PR #720 which fixes 'language-server-ruby/src/linters/' and this PR is fixing 'language-server-ruby/src/formatters/' (which has the same issue -- extra single quotes).

I made the modifications on my previous setup and don't have a Ruby setup anymore and don't know TS enough to add a test. I marked the PR so that maintainers can add more commits if they want to.

qwell commented 1 year ago

I created PR #840, which undoes all of the other places that were touched by PR #647. It may be best to merge that into this, but if you're not doing Ruby anymore, I don't know.

@Buzzkill-McSquare in regards to tests...

None of the changes that broke and then subsequently partially fixed these areas have had any. While I always love to see proper testing, I hold a very strong opinion about this not waiting for somebody to happen to come around to write them. This is broken and has been broken for over 2 years.

Buzzkill-McSquare commented 1 year ago

Agreed. I'd love to help with writing those tests, but I don't have the experience around writing extensions. I approved your linked PR, but since I'm not an actual contributor I don't think it counts.

github-actions[bot] commented 1 year ago

This PR has not had activity for 30 days. It will be automatically closed in 30 days.

senhalil commented 1 year ago

Can't understand what's taking so long, it is a two character fix.

How can we get the attention of a maintainer?