rubyjs / libv8-node

Package libv8 from Node
MIT License
14 stars 27 forks source link

Update to node v17.3.1 #31

Closed nightpool closed 2 years ago

nightpool commented 2 years ago

This also includes a performance improvement for the build_monolith.sh script, which is to invoke ar once with all of the libraries to be included, rather then building it incrementally. Because of how ar creates a copy of the archive to update rather then updating the archive file in place, this speeds up the creation of the archive file significantly (When building with debug symbols, build_monolith.sh alone was taking >12 hours, and now takes 30ish minutes).

lloeki commented 2 years ago

Thanks for this update @nightpool!

lloeki commented 2 years ago

invoke ar once with all of the libraries to be included, rather then building it incrementally

I can't recall why I did that, I think it was when trying to debug some specific symbol missing situations, and then having split ar calls made them appear for some reason.

tisba commented 2 years ago

Hey @lloeki. Any plans on releasing a new version yet? Especially https://github.com/rubyjs/libv8-node/issues/27 would be interesting, since a bunch of mini_racer installation issues are caused by this.

I don't know much about building C/C++ projects, but I'm happy to help where I can (I have Intel and M1 hardware available).

lloeki commented 2 years ago

Yup, plans indeed, it's just that I had to pull off some double shifts last month to reach some goals.

So plans are a) recover a bit from that b) build and push missing aarch64 musl lib and a new fat libc+musl c) build and push 17.x d) get aarch64 musl cross compiling sorted out

SamSaffron commented 2 years ago

@lloeki any chance we can do a release? perhaps we can add @nightpool to the rotation of people who can do the releases to decrease bus factor?

lloeki commented 2 years ago

I'm AFK til next week (checking things on phone), I'll do the release then and add @nightpool as suggested.