Open abartov opened 1 year ago
seanmakesgames
commented
1 year ago Hey @abartov - thanks for posting your issue. Did you figure out a workaround already? I don't think @lloeki has posted the new binaries that we've been working on, yet.
This might be fixed with our recent changes.
abartov
commented
1 year ago @seanmakesgames - no, I haven't found a workaround. I've paused my upgrade and will wait for this to be resolved before resuming.
lloeki
commented
1 year ago Hey, I've been swamped lately (big deadline at work), sorry for the delays. I'll build+push the updated builds later this week.
despite having the Python versions it asks for (3.10, 3.9, as well as 2.7).
Node.js configure: Found Python 2.7.18.
Usually this is because the NodeJS detection here is a bit lousy and there's a python2 lying around as python in the path, or something to that effect. I tried to work around that here
You could fix that by:
PYTHON env var to point to one of your python3 (at some point there were issues with that as not every place was using that env var)python pointing to python3 in your path (e.g mkdir /some/path && ln -sf /usr/bin/python3 /some/path/python && env PATH="/some/path:$PATH yourcommandthatfailed")seanmakesgames
commented
1 year ago Let us know if you try it and how it goes!
Fayti1703
commented
1 year ago Usually this is because the NodeJS detection here is a bit lousy and there's a
python2lying around aspythonin the path, or something to that effect. I tried to work around that here
I want to add that the linked code snippet here was removed by me in the current node-17-HEAD (4411451acfc893f01fa8cab761a91476bf5f046b) since it caused issues building on darwin CI.
However, Node.JS's configure script looks like it tries to find an appropriate python version if it is present in the PATH, see its header:
#!/bin/sh
# Locate an acceptable Python interpreter and then re-execute the script.
# Note that the mix of single and double quotes is intentional,
# as is the fact that the ] goes on a new line.
_=[ 'exec' '/bin/sh' '-c' '''
command -v python3.10 >/dev/null && exec python3.10 "$0" "$@"
command -v python3.9 >/dev/null && exec python3.9 "$0" "$@"
command -v python3.8 >/dev/null && exec python3.8 "$0" "$@"
command -v python3.7 >/dev/null && exec python3.7 "$0" "$@"
command -v python3.6 >/dev/null && exec python3.6 "$0" "$@"
command -v python3 >/dev/null && exec python3 "$0" "$@"
exec python "$0" "$@"
''' "$0" "$@"
]
del _Note to people watching these issues & PRs-- We are trying to release new versions of libv8-node and mini_racer and would love your help testing for stability in your products. Here's the main issue thread where we are tracking this: https://github.com/rubyjs/mini_racer/issues/277
Please let us know the results of your tests in our branches so we can do the actual releases on those branches with confidence.
The gem doesn't build, despite having the Python versions it asks for (3.10, 3.9, as well as 2.7).