Closed tisba closed 1 year ago
this looks good to me!
odd that truffle is failing atm @eregon ?
https://github.com/rubyjs/mini_racer/actions/runs/5083216358/jobs/9133946519 Thanks for the ping. It seems it tries to compile libv8-node instead of using the precompiled gem as intended (because it doesn't need it anyway). Maybe some issue in Bundler, I'll try to repro locally.
BTW https://github.com/rubyjs/libv8-node/commit/abae20efae1b93ee686f2c0a7b5a7197e386b83a would fix this but mini_racer imports an older version of libv8-node.
Yes, it's simply https://github.com/rubygems/rubygems/issues/6165, I'll try to use a newer Bundler to avoid this issue.
I Fixed some typos and other nit-picky whitespace stuff in CHANGELOG.
I made a bit more changes to the README. I actually wanted to fix some typos and move the troubleshooting up based on issues opened by users having trouble installing mini_racer, but then I guess I got carried away and tried to make some more improvements 😁
print()
was called, but it wasn't needed to showcase the feature anyway so I just dropped thatPlease let me know if that's too much in one go and I can split this up for easier review.