search

rubyjs / mini_racer

Minimal embedded v8
MIT License
585 stars 91 forks source link

Update to libv8-node 19.x #283

Closed lloeki closed 3 months ago

Fayti1703 commented 1 year ago

Not sure if this is one issue or two issues, but that looks like a problem with managing V8 locks... Going to try and debug this in a bit.

lloeki commented 1 year ago

Awesome, thanks @Fayti1703

tisba commented 1 year ago

Still WIP, but looks like we're changing the requirements for compiling mini_racer. If that's the case, we should probably also update the README (https://github.com/rubyjs/mini_racer#installation), which currently mentions:

Note using v8.h and compiling MiniRacer requires a C++11 standard compiler, more specifically clang 3.5 (or later) or GCC 6.3 (or later).

I was also wondering if we should add a section to the README regarding supported macOS versions. I think @lloeki mentioned somewhere that the minimum supported macOS version changed with some v8 version.

Fayti1703 commented 1 year ago

I appear to be having a task-dependency issue when compiling locally:

Circular dependency detected:
TOP =>
compile =>
compile:x86_64-linux-gnu =>
compile:mini_racer_loader:x86_64-linux-gnu =>
copy:mini_racer_loader:x86_64-linux-gnu:3.0.2 =>
tmp/x86_64-linux-gnu/stage/lib/mini_racer_extension.so =>
lib/mini_racer_extension.so =>
copy:mini_racer_extension:x86_64-linux-gnu:3.0.2 =>
tmp/x86_64-linux-gnu/stage/lib/mini_racer_loader.so =>
copy:mini_racer_loader:x86_64-linux-gnu:3.0.2

This also occurs with v0.8.0, but not with v0.6.4. (using Bundler version 2.3.22 & ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux-gnu])

Going to try running a bisect, see if I can track down what exactly the problem is here.

Fayti1703 commented 1 year ago

Looks to be caused by 657a6ffcbfb84d2de34efe3204654a06b2d9dc3e...? (That is, my problem; not the v8 abort)

Fayti1703 commented 1 year ago

I've managed to pin down two issues here:

Fayti1703 commented 1 year ago

With a debug build of V8 (via a local libv8-node gem build), I get even more snapshot-related crashes due to invalid checksums. V8 says (for example):

#
# Fatal error in ../deps/v8/src/heap/read-only-spaces.cc, line 71
# Check failed: read_only_blob_checksum_ == snapshot_checksum (<unprintable> vs. 3847049538).
#

This smells like a V8 bug, since as far as I can tell MR doesn't touch the snapshot data whatsoever.

lloeki commented 1 year ago

This smells like a V8 bug

@Fayti1703 Did you by any chance attempt anything with node 20?

Fayti1703 commented 1 year ago

Not yet -- though judging from the CI runs on #284, there's similar behavior on that version as well.

I was planning on dumping out the checksum data on snapshot generation, trying to see if anything was off there (which would basically confirm it being a V8 issue), but I haven't found the time to do so yet.

lloeki commented 10 months ago

A few weeks ago I made a half-hearted attempt to trace things using GDB reverse debugging time travel, but no dice.

Half-hearted because I was not very hopeful as GDB RD is quite limited + my RD skills are limited. A more potent RD is rr, but I'm not well versed with it, although I'm a bit more hopeful: when I got stuck with GDB RD falling short, someone managed to find stuff with rr.

Maybe it's time I ramp my RD+rr game up.

tisba commented 10 months ago

Out of curiosity: by rr you are referring to https://github.com/rr-debugger/rr?

lloeki commented 10 months ago

Yup, some vids are down below: https://rr-project.org

lloeki commented 3 months ago

I've moved to attempt things straight on node 20 here: https://github.com/rubyjs/mini_racer/pull/284

lloeki commented 3 months ago

Merging this as is as per the plan.