search

rubyjs / mini_racer

Minimal embedded v8
MIT License
594 stars 93 forks source link

CI: Fix "::set-output" deprecation #287

Closed tisba closed 10 months ago

tisba commented 1 year ago

Looks like Github is postponing the removal, but IMO we should still address this, see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/:

Our telemetry shows significant usage of these commands. Given the number of impacted customers we are postponing the removal.

SCR-20230605-iccc
tisba commented 1 year ago

hmm, we might want to set a reasonable timeout on our jobs maybe. Looks like the macOS truffleruby job hang for 6 hours without making progress 🤷

In any case, has (most likely) nothing to do with this changeset.

tisba commented 1 year ago

Feel free to merge @lloeki (I can't).