Added support for windows and mingw.

rubyjs / therubyracer

Embed the V8 Javascript Interpreter into Ruby

1.66k stars 191 forks source link

Added support for windows and mingw. #337

Open jarredholman opened 9 years ago

jarredholman commented 9 years ago

Depends on this pull request: https://github.com/cowboyd/libv8/pull/166

Renamed the "access" variable as this appears to be a macro on windows.

cowboyd commented 9 years ago

@jarredholman Do you think you can replicate that appveyor magic like over on libv8?

jarredholman commented 9 years ago

Sure. It will be a bit hackish initially so that it will accept the rc1'd libv8 version

cowboyd commented 9 years ago

Hmm, maybe we should just release.

ignisf commented 9 years ago

I'm having the same problem with the ARM guys again -- I've made the changes they requested but I'm having zero feedback from them. I wrote in the issue last night, no response yet. Your call.

edouardb commented 9 years ago

The issue is still present with 3.16.14.8.rc1 Tried it with discourse, https://github.com/discourse/discourse_docker/issues/121