search

rubyjs / therubyracer

Embed the V8 Javascript Interpreter into Ruby
1.66k stars 193 forks source link

Updated libv8 version #418

Closed jneuendorf closed 7 years ago

jneuendorf commented 8 years ago

Hi,

installing therubyracer fails on macOS Sierra because building libv8 fails. For some reason version 3.16.14.15 works on macOS Sierra (see this issue) and since only patches have been applied since the currently used version of libv8 (3.16.14.0) I guess there should be no bad consequences, right? ^^ Some of the changes are documented in libv8's changelog.

I would be awesome if the PR would be merged so I can get my rails app back up running on my new system. Thanks! :)

ignisf commented 8 years ago

@jneuendorf if you do a bundle update libv8 you should be able to use therubyracer. Having said that, I can think of no good reason not to merge this and cut a release.

ignisf commented 8 years ago

Though it might be necessary to bump the libv8 version here, too:

https://github.com/cowboyd/therubyracer/blob/master/ext/v8/extconf.rb#L19

jneuendorf commented 8 years ago

@ignisf Thanks for the fast response! :) I am more responsible for the front end programming of the rails app I mentioned above (and not tooo familiar with ruby/rails) and therefore I didn't know what ~> means. bundle update libv8 worked for me - thank you for that. I'll update the extconf.rb file later tonight.

ignisf commented 8 years ago

Glad to be of assistance and thank you for taking the time to open a PR!

snuggs commented 7 years ago

@cowboyd can we slice a version bump?