search

rubyjs / therubyracer

Embed the V8 Javascript Interpreter into Ruby
1.66k stars 193 forks source link

TypeError when require'ing on Ruby 2.4 #427

Closed denisdefreyne closed 7 years ago

denisdefreyne commented 7 years ago

On Ruby 2.4, therubyracer cannot be required:

require 'therubyracer'
TypeError: wrong argument type Class (expected Module)
    from /usr/local/lib/ruby/gems/2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:23:in `include'
    from /usr/local/lib/ruby/gems/2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:23:in `block (2 levels) in <top (required)>'
    from /usr/local/lib/ruby/gems/2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:22:in `class_eval'
    from /usr/local/lib/ruby/gems/2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:22:in `block in <top (required)>'
    from /usr/local/lib/ruby/gems/2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:21:in `each'
    from /usr/local/lib/ruby/gems/2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:21:in `<top (required)>'
    from /usr/local/Cellar/ruby/2.4.0/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
…
denisdefreyne commented 7 years ago

This is already fixed in f2ccbad7e9e3899e8743624d9b1436500100420a!

spickermann commented 7 years ago

Great that this is already fixed. Thanks a lot.

What are your plans about releasing a new version via rubygems.org?

ignisf commented 7 years ago

I've pinged @cowboyd. Hopefully soon.

ignisf commented 7 years ago

https://github.com/cowboyd/therubyracer/issues/430 created for tracking the release