search

rubyjs / therubyrhino

Embed the Mozilla Rhino Javascript interpreter into Ruby
155 stars 40 forks source link

deprecations between 1.73.0 and 1.73.1 #11

Closed atambo closed 12 years ago

atambo commented 12 years ago

After upgrading thrubyrhino from 1.73.0 to 1.73.1 I get the following deprecation warnings when running my selenium tests using rspec 2.8 and selenium-webdriver 2.18.0:

[DEPRECATION] `Rhino::To.ruby` is deprecated, use `Rhino.to_ruby` instead.
[DEPRECATION] `Rhino::NativeFunction` is no longer used, returning a stub.
[DEPRECATION] `Rhino::NativeObject` is no longer used, returning a stub.
atambo commented 12 years ago

@kares seems like the person who introduced a lot of these deprecations. Should selenium-webdriver be notified of these changes?

kares commented 12 years ago

Definitely, if you're willing to depend on 1.73.1+ there has been some refactoring in the way rhino works e.g. NativeX wrappers are no longer used - Rhino's classes are returned instead e.g. instances of Rhino::JS::Function. Some gems need to update e.g. ExecJS but still shoud work (with those deprecations) if they do not monkey-patch therubyrhino or depend on some internal functionality.

sent from my phone On Jan 31, 2012 6:28 PM, "Alex Tambellini" < reply@reply.github.com> wrote:

@kares seems like the person who introduced a lot of these deprecations. Should selenium-webdriver be notified of these changes?

Reply to this email directly or view it on GitHub: https://github.com/cowboyd/therubyrhino/issues/11#issuecomment-3743487