rubyjs / therubyrhino

Embed the Mozilla Rhino Javascript interpreter into Ruby
155 stars 40 forks source link

Travis: Choose Trusty to build, have language Ruby #35

Closed olleolleolle closed 7 years ago

olleolleolle commented 7 years ago

This WIP PR tries to update the builds so that they run on the supported platforms.

Issues we ran into:

Observations:

kares commented 7 years ago

thanks, unfortunately the specs do not boot - could you maybe try resolving the rspec compatibility issues?

olleolleolle commented 7 years ago

@kares (Will jruby-18mode remain a requirement?)

kares commented 7 years ago

@olleolleolle do not see why the requirements should change due travis-ci ... only if there was more work

also please keep the new failures at minimum :)


[!] There was an error parsing `Gemfile`: There are multiple gemspecs at /home/travis/build/cowboyd/therubyrhino. Please use the :name option to specify which one should be used. Bundler cannot continue.

 #  from /home/travis/build/cowboyd/therubyrhino/Gemfile:3
 #  -------------------------------------------
 #  
 >  gemspec
 #  
 #  -------------------------------------------
olleolleolle commented 7 years ago

@kares This is me trying to get the gemspec :name => 'therubyrhino' invocation to work. Update: This was just me being confused.

olleolleolle commented 7 years ago

This was the error that jruby-9.1.8.0 reported.

[!] There was an error parsing `Gemfile`: 
[!] There was an error while loading `therubyrhino.gemspec`: . Bundler cannot continue.
. Bundler cannot continue.
 #  from /home/travis/build/cowboyd/therubyrhino/Gemfile:3
 #  -------------------------------------------
 #  
 >  gemspec :name => "therubyrhino"
 #  
 #  -------------------------------------------
olleolleolle commented 7 years ago

(9.1.7.0 can run bundle exec rake on my OS X machine.)

olleolleolle commented 7 years ago

There's code where Bundler tries to parse out useful descriptive lines from the backtrace.

https://github.com/bundler/bundler/blob/9f414c55be8b749f46a0470277f14572c5246c03/lib/bundler/dsl.rb#L515

https://github.com/bundler/bundler/blob/9f414c55be8b749f46a0470277f14572c5246c03/lib/bundler/dsl.rb#L543-L551

This may fail on JRuby 9.1.8.0 with a ~dramatic bang~ whimper - where Bundler is unable to find anything that relates to the package at hand in the backtrace.

kares commented 7 years ago

I think the NPE has been introduced along the way with a commit (maybe a rhino.jar upgrade). code has been always a little edgy on cases, but those features are very unlikely to be used at all. I'm fine to merge this as is since it now at least runs the specs on CI.

olleolleolle commented 7 years ago

@kares Squashed change to a single commit.

kares commented 7 years ago

@olleolleolle Thanks!