search

rubyjs / therubyrhino

Embed the Mozilla Rhino Javascript interpreter into Ruby
155 stars 40 forks source link

JRuby 1.9 compatibility #5

Closed alexkwolfe closed 13 years ago

alexkwolfe commented 13 years ago

This pull request contains:

cowboyd commented 13 years ago

Hey Alex,

Thanks for doing all this work. I apologize for only getting to it now. I'm having a look as we speak.

alexkwolfe commented 13 years ago

Man. I didn't see the redjs submodule. Looks like the specs are failing after initing and updating the submodule. Not sure if I did that, but I'll look into it.

cowboyd commented 13 years ago

No, it has fallen out of date. I'm working to get the specs passing again.

On Oct 5, 2011, at 9:46 PM, Alex Wolfe wrote:

Man. I didn't see the redjs submodule. Looks like the specs are failing after initing and updating the submodule. Not sure if I did that, but I'll look into it.

Reply to this email directly or view it on GitHub: https://github.com/cowboyd/therubyrhino/pull/5#issuecomment-2305949

alexkwolfe commented 13 years ago

I see that now. On the master branch running the specs under 1.9, a bunch more specs fail. With these commits, howevver, we're back to the same failing specs again, it looks like.

cowboyd commented 13 years ago

we're down to 20 failing specs! Good to see the rhino getting some love!

alexkwolfe commented 13 years ago

That's weird. I only have 5 specs failing:

rspec ./spec/redjs/jsapi_spec.rb:53 # Ruby Javascript API Basic Evaluation can pass objects back to ruby
rspec ./spec/redjs/jsapi_spec.rb:150 # Ruby Javascript API Calling Ruby Code From Within Javascript translated camel case properties are enumerated by default, but perl case are not
rspec ./spec/redjs/jsapi_spec.rb:207 # Ruby Javascript API Calling Ruby Code From Within Javascript it silently fails to replace properties which are defined on ruby objects but which are read-only
rspec ./spec/redjs/jsapi_spec.rb:251 # Ruby Javascript API Setting up the Host Environment can directly embed ruby values into javascript
rspec ./spec/rhino/context_spec.rb:37 # Rhino::Context Initalizing Standard Javascript Objects allows you to seal the standard objects so that they cannot be modified
cowboyd commented 13 years ago

I've pushed a newer version of jsapi that is what therubyracer uses. These are mostly edge cases that are failing, and don't represent catastrophic failure, but there's no reason not to get them working.